Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(ci): more lenient recovery #8462

Merged
merged 1 commit into from
Sep 23, 2024
Merged

chore(ci): more lenient recovery #8462

merged 1 commit into from
Sep 23, 2024

Conversation

ludamad
Copy link
Collaborator

@ludamad ludamad commented Sep 9, 2024

Jean seems to have hit an edge-case, change this to be best-effort

Jean seems to have hit an edge-case, change this to be best-effort
@AztecBot
Copy link
Collaborator

AztecBot commented Sep 9, 2024

Benchmark results

Metrics with a significant change:

  • proof_construction_time_sha256_30_ms (16): 1,702 (+22%)
  • avm_simulation_time_ms (Token:mint_public): 313 (+624%)
  • avm_simulation_time_ms (Token:assert_minter_and_mint): 61.5 (-81%)
  • avm_simulation_time_ms (Token:_increase_public_balance): 55.4 (+43%)
Detailed results

All benchmarks are run on txs on the Benchmarking contract on the repository. Each tx consists of a batch call to create_note and increment_balance, which guarantees that each tx has a private call, a nested private call, a public call, and a nested public call, as well as an emitted private note, an unencrypted log, and public storage read and write.

This benchmark source data is available in JSON format on S3 here.

Proof generation

Each column represents the number of threads used in proof generation.

Metric 1 threads 4 threads 16 threads 32 threads 64 threads
proof_construction_time_sha256_ms 5,746 1,550 699 (-1%) 780 (+3%) 770 (-1%)
proof_construction_time_sha256_30_ms 11,583 3,088 ⚠️ 1,702 (+22%) 1,592 (+12%) 1,511 (+3%)
proof_construction_time_sha256_100_ms 45,635 11,822 (-1%) 5,416 (-6%) 6,168 (+5%) 5,699 (+4%)
proof_construction_time_poseidon_hash_ms 78.0 34.0 34.0 57.0 (-2%) 87.0 (-1%)
proof_construction_time_poseidon_hash_30_ms 1,531 416 199 230 (+4%) 265 (-1%)
proof_construction_time_poseidon_hash_100_ms 5,635 1,497 665 (-1%) 720 740 (-1%)

L2 block published to L1

Each column represents the number of txs on an L2 block published to L1.

Metric 4 txs 8 txs 16 txs
l1_rollup_calldata_size_in_bytes 4,356 7,876 14,884
l1_rollup_calldata_gas 50,184 92,968 178,132
l1_rollup_execution_gas 843,025 1,576,705 3,361,925
l2_block_processing_time_in_ms 242 460 800 (+1%)
l2_block_building_time_in_ms 11,505 (+1%) 23,317 (+4%) 45,086
l2_block_rollup_simulation_time_in_ms 11,505 (+1%) 23,316 (+4%) 45,086
l2_block_public_tx_process_time_in_ms 9,809 21,586 (+4%) 43,358

L2 chain processing

Each column represents the number of blocks on the L2 chain where each block has 8 txs.

Metric 3 blocks 5 blocks
node_history_sync_time_in_ms 3,421 (+1%) 4,463 (+1%)
node_database_size_in_bytes 14,221,552 18,235,632
pxe_database_size_in_bytes 16,258 26,818

Circuits stats

Stats on running time and I/O sizes collected for every kernel circuit run across all benchmarks.

Circuit simulation_time_in_ms witness_generation_time_in_ms input_size_in_bytes output_size_in_bytes proving_time_in_ms
private-kernel-init 75.4 386 (-1%) 21,027 44,933 N/A
private-kernel-inner 141 675 (-1%) 71,803 45,067 N/A
private-kernel-reset-tiny 288 674 (+1%) 64,669 44,922 N/A
private-kernel-tail 151 (+1%) 127 (-2%) 50,553 57,178 N/A
base-parity 5.53 N/A 160 96.0 N/A
root-parity 35.6 (+1%) N/A 73,964 96.0 N/A
base-rollup 2,643 (+2%) N/A 189,128 664 N/A
block-root-rollup 41.3 (-1%) N/A 58,217 2,448 N/A
public-kernel-setup 86.6 (+4%) N/A 114,433 79,670 N/A
public-kernel-app-logic 99.3 (+2%) N/A 114,251 79,670 N/A
public-kernel-tail 860 (+2%) N/A 487,098 16,414 N/A
private-kernel-reset-small 272 (+1%) N/A 66,345 45,629 N/A
private-kernel-tail-to-public 1,330 (-12%) 596 (-1%) 449,631 1,825 N/A
public-kernel-teardown 84.8 (+1%) N/A 114,697 79,670 N/A
merge-rollup 21.0 (+5%) N/A 38,182 664 N/A
undefined N/A N/A N/A N/A 83,380 (+2%)

Stats on running time collected for app circuits

Function input_size_in_bytes output_size_in_bytes witness_generation_time_in_ms
ContractClassRegisterer:register 1,344 11,731 342 (-1%)
ContractInstanceDeployer:deploy 1,408 11,731 18.2
MultiCallEntrypoint:entrypoint 1,920 11,731 420
FeeJuice:deploy 1,376 11,731 393 (+2%)
SchnorrAccount:constructor 1,312 11,731 59.6 (-1%)
SchnorrAccount:entrypoint 2,336 11,731 367 (-1%)
FeeJuice:claim 1,344 11,731 36.9 (+2%)
Token:privately_mint_private_note 1,280 11,731 73.8 (+4%)
FPC:fee_entrypoint_public 1,344 11,731 24.7 (+2%)
Token:transfer 1,312 11,731 209 (-3%)
Benchmarking:create_note 1,344 11,731 74.6 (+1%)
SchnorrAccount:verify_private_authwit 1,280 11,731 26.6
Token:unshield 1,376 11,731 488 (+1%)
FPC:fee_entrypoint_private 1,376 11,731 641

AVM Simulation

Time to simulate various public functions in the AVM.

Function time_ms bytecode_size_in_bytes
FeeJuice:_increase_public_balance 165 (+2%) 2,283
FeeJuice:set_portal 13.0 (+29%) 2,610
Token:constructor 71.3 (-4%) 12,960
FPC:constructor 48.3 (-3%) 7,766
FeeJuice:check_balance 37.7 2,002
Token:mint_public ⚠️ 313 (+624%) 4,441
Token:assert_minter_and_mint ⚠️ 61.5 (-81%) 2,921
AuthRegistry:set_authorized 36.9 (+1%) 945
FPC:prepare_fee 67.9 (+3%) 3,947
Token:transfer_public 16.5 (-18%) 8,909
FPC:pay_refund 40.4 (-6%) 4,873
Benchmarking:increment_balance 1,238 (+1%) 3,146
Token:_increase_public_balance ⚠️ 55.4 (+43%) 2,260
FPC:pay_refund_with_shielded_rebate 50.0 (-3%) 4,873

Public DB Access

Time to access various public DBs.

Function time_ms
get-nullifier-index 0.166 (+2%)

Tree insertion stats

The duration to insert a fixed batch of leaves into each tree type.

Metric 1 leaves 16 leaves 64 leaves 128 leaves 256 leaves 512 leaves 1024 leaves
batch_insert_into_append_only_tree_16_depth_ms 2.16 (+1%) 4.01 (+1%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_count 16.7 31.8 N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_16_depth_hash_ms 0.113 (+1%) 0.112 (+1%) N/A N/A N/A N/A N/A
batch_insert_into_append_only_tree_32_depth_ms N/A N/A 11.3 (+1%) 17.8 (+1%) 31.0 (+1%) 60.7 (+1%) 113
batch_insert_into_append_only_tree_32_depth_hash_count N/A N/A 95.9 159 287 543 1,055
batch_insert_into_append_only_tree_32_depth_hash_ms N/A N/A 0.108 (+1%) 0.103 (+1%) 0.101 (+1%) 0.105 (+2%) 0.102
batch_insert_into_indexed_tree_20_depth_ms N/A N/A 14.4 (+2%) 26.0 44.1 84.9 (+1%) 160 (-2%)
batch_insert_into_indexed_tree_20_depth_hash_count N/A N/A 109 207 357 691 1,363
batch_insert_into_indexed_tree_20_depth_hash_ms N/A N/A 0.110 (+2%) 0.105 (+1%) 0.103 (-3%) 0.106 (+2%) 0.101 (-2%)
batch_insert_into_indexed_tree_40_depth_ms N/A N/A 16.5 (+2%) N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_count N/A N/A 129 N/A N/A N/A N/A
batch_insert_into_indexed_tree_40_depth_hash_ms N/A N/A 0.108 (+2%) N/A N/A N/A N/A

Miscellaneous

Transaction sizes based on how many contract classes are registered in the tx.

Metric 0 registered classes 1 registered classes
tx_size_in_bytes 72,416 668,302

Transaction size based on fee payment method

| Metric | |
| - | |

@ludamad ludamad closed this Sep 13, 2024
@ludamad ludamad reopened this Sep 23, 2024
@ludamad ludamad merged commit 5d9a2fe into master Sep 23, 2024
101 checks passed
@ludamad ludamad deleted the ad/chore-ci-recovery-fix branch September 23, 2024 18:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants