Add tvOS 13 to if available checks in Presentation Manager #360
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sources/Managers/APIManager.swift
Outdated
| @@ -114,6 +114,11 @@ extension APIManager { | |||
|
|
|||
| var items: [URLQueryItem] = [URLQueryItem(name: Constants.bundleID, value: Bundle.main.bundleIdentifier)] | |||
|
|
|||
| #if os(tvOS) | |||
| let tvOSQueryItem = URLQueryItem(name: "entity", value: "tvSoftware") | |||
There was a problem hiding this comment.
can you explain the name and value here? Is it documented somewhere? I'm having a hard time finding this info. Thank you!
There was a problem hiding this comment.
I found this from https://developer.apple.com/forums/thread/30633 and https://discussions.apple.com/thread/7922201
Looks like, as of 3 years ago or so, this is undocumented by Apple, but definitely does the trick to pull back tvOS App Store data from their query REST API.
|
Thanks for the PR! I left a comment for clarification. Thanks! |
|
Thank you! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm working on a project that has an iOS as well as a tvOS version of the app. When I tried compiling the project with Siren against our tvOS target, it does not compile, as a result of the if #available checks in the Presentation manager. tvOS reasonably handles presenting an Alert (albeit as a full-screen overlay) and it works just fine in tvOS. As in iOS, it's difficult to test on a tvOS simulator, but on an actual AppleTV device, it does redirect to the App Store app to download the newest version just like iOS.