Local setup #231
Local setup #231
Conversation
Dockerfile
Outdated
There was a problem hiding this comment.
My editor linted Dockerfile. Not sure if interested.
There was a problem hiding this comment.
these lint changes look good
Procfile.dev
Outdated
| @@ -1,2 +1,3 @@ | |||
| web: env RUBY_DEBUG_OPEN=true bin/rails server -p ${PORT:-3000} | |||
| postgres: docker-compose up postgres | |||
There was a problem hiding this comment.
This was missing to start up with bin/dev
There was a problem hiding this comment.
This doesn’t seem right to me.
My mental mode has been: there are two methods of running this app, Procfile OR docker compose. Meaning, if you have docker installed and want to use docker compose, you just run “docker compose up” and everything starts: puma, postgres, and redis. But if you don’t want to install docker and you prefer to install postgres and redis through brew (or whatever means to get them installed directly on your dev machine) then you use the Procfile. So having the Procfile execute docker doesn’t seem right.
There was a problem hiding this comment.
you're right. Will revert.
I've been transitioning my local setup recently and I haven't found my ideal config yet.
There was a problem hiding this comment.
Aligned with the latest version of Rails but also added overmind command if already installed. (overmind is a more modern approach to foreman but act similar).
bin/dev
Outdated
| if command -v overmind &> /dev/null; then | ||
| overmind start -f Procfile.dev "$@" | ||
| else | ||
| foreman start -f Procfile.dev "$@" |
There was a problem hiding this comment.
@olimart In this conditional, it's possible the person doesn't have foreman either. Shall we keep the "gem install" block that you removed above but put it down here within this branch of the conditional?
There was a problem hiding this comment.
we should indeed. I've added it back. thanks
I tweaked a bit the setup through Procfile.
Please see comments inline.