-
Notifications
You must be signed in to change notification settings - Fork 3.7k
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Persistent docker doesn't work with AgentSkills in test #2176
Comments
Creating an issue to track the problem |
works if
The typical two lines are missing. Open to suggestions! |
New issue - pip not found was raised after this. Are there any tests that clear sandbox storage? |
|
@li-boxuan can this issue be closed now that PERSIST_SANDBOX is set to false by default and likely needs an overhaul if implemented correctly? |
@mamoodi I think we should keep this issue open unless we fix it, remove PERSIST_SANDBOX completely, OR have another issue/PR that tracks an overhaul? |
Makes sense. Let's keep it open until one of those happen. I think what needs to be done is a little bit in the air. |
This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This issue is stale because it has been open for 30 days with no activity. Remove stale label or comment or this will be closed in 7 days. |
This issue was closed because it has been stalled for over 30 days with no activity. |
Persistent docker thing doesn't seem to work well with agent skills. Repro command:
(with
persist_sandbox = true
)I think #1998 causes a regression.
The test passed because you set
persist_sandbox = false
in CI.If we make this persistence thing by default ON, we shall probably also turn it on in CI?
Originally posted by @li-boxuan in #2139 (comment)
The text was updated successfully, but these errors were encountered: