Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: Add vault tabs in Vault details UI #11

Merged
merged 1 commit into from
Jun 30, 2023

Conversation

luchobonatti
Copy link
Collaborator

Description

Adding New Strategy, History and Positions tabs in vault details with mock data.

Closes #10

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

How Has This Been Tested?

Please describe the tests that you ran to verify your changes.

  • Go to strategies page
  • Select a previously created vault
  • In the vault details page you can see the 3 tabs mentioned.

Checklist

  • My code follows the style guidelines of this project
  • I have performed a self-review of my code
  • I have commented my code in hard-to-understand areas
  • I have made corresponding changes to the documentation
  • My changes generate no new warnings
  • I have added tests that prove my fix is effective or that my feature works
  • New and existing unit tests pass locally with my changes

@luchobonatti luchobonatti changed the base branch from main to feature/short-long-ui June 28, 2023 16:46
@luchobonatti luchobonatti changed the base branch from feature/short-long-ui to feature/strategies June 30, 2023 16:50
@luchobonatti luchobonatti merged commit cde5cbc into feature/strategies Jun 30, 2023
3 checks passed
@luchobonatti luchobonatti deleted the feature/vault-tabs-ui branch June 30, 2023 18:14
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add vault Tabs (new Strategy, History, Positions)
1 participant